Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PR template #2224

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Change PR template #2224

merged 3 commits into from
Jun 18, 2020

Conversation

edenlightning
Copy link
Contributor

What does this PR do?

Update Lightning PR template.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team June 17, 2020 16:23
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 17, 2020 17:20
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo :)

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 17, 2020 21:20
@Borda Borda added the docs Documentation related label Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2224 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2224   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5420    5420           
======================================
  Hits         4760    4760           
  Misses        660     660           

@Borda Borda merged commit f8c10fb into master Jun 18, 2020
@Borda Borda deleted the pr_template branch June 18, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants